Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pre-commit-config.yaml #983

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Add .pre-commit-config.yaml #983

merged 1 commit into from
Sep 22, 2023

Conversation

eurunuela
Copy link
Collaborator

@eurunuela eurunuela commented Sep 22, 2023

Closes None.

I just realized that for some reason #973 did not include the pre-commit config file. It got removed when I reverted a commit to avoid auto-formatting on save. Sorry about that.

Changes proposed in this pull request:

  • Add the pre-commit config file.

Edit: I guess a single review should be enough to merge this one.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d11f021) 89.00% compared to head (658f7b2) 89.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #983   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files          27       27           
  Lines        3411     3411           
  Branches      622      622           
=======================================
  Hits         3036     3036           
  Misses        227      227           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@handwerkerd
Copy link
Member

@tsalo You have time to do a quick sanity check review before we merge?

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with pre-commit configurations, but this config makes sense to me.

@handwerkerd handwerkerd merged commit 133b3b5 into ME-ICA:main Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants